Skip to content

Expand sesame2spiner input syntax#623

Merged
Yurlungur merged 5 commits intomainfrom
dempsey/s2s_input
Mar 30, 2026
Merged

Expand sesame2spiner input syntax#623
Yurlungur merged 5 commits intomainfrom
dempsey/s2s_input

Conversation

@adamdempsey90
Copy link
Copy Markdown
Collaborator

PR Summary

As discussed in #622 . Despite the AI tag for that issue, I did not use AI.

I have modified the unit tests to call sesame2spiner on one combined input file, so if the tests pass, it works.

Closes #622

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@adamdempsey90 adamdempsey90 requested a review from Yurlungur March 28, 2026 00:04
Copy link
Copy Markdown
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Assuming tests pass on re-git.

Comment on lines +44 to +48
// make sure there's no trailing comment
auto comment_pos = value.find("#");
if (comment_pos != std::string::npos) {
value.erase(comment_pos);
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamdempsey90
Copy link
Copy Markdown
Collaborator Author

LGTM. Assuming tests pass on re-git.

Tests all pass

@Yurlungur Yurlungur merged commit 2efce3b into main Mar 30, 2026
9 checks passed
@Yurlungur Yurlungur deleted the dempsey/s2s_input branch March 30, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sesame2spiner input improvements

2 participants